Dark theme tweak [solved]

Report Bugs, Issues and non- package Requests
Message
Author
User avatar
colin_b
Posts: 452
Joined: Sun Mar 19, 2017 7:21 pm

Dark theme tweak [solved]

#1 Post by colin_b »

I'm using MX17.1 with a dark theme on a live USB with persistence enabled. When I check the dark theme tweak it works as advertised on Firefox. After a reboot the dark theme tweak checkbox still shows enabled, but when Firefox is used the tweak is no longer applied.

Is this down to running MX on a live USB?
Last edited by colin_b on Thu Jul 12, 2018 11:19 pm, edited 1 time in total.

User avatar
Jerry3904
Administrator
Posts: 21937
Joined: Wed Jul 19, 2006 6:13 am

Re: Dark theme tweak

#2 Post by Jerry3904 »

If you're not using persistence, it won't persist, right?
Production: 5.10, MX-23 Xfce, AMD FX-4130 Quad-Core, GeForce GT 630/PCIe/SSE2, 16 GB, SSD 120 GB, Data 1TB
Personal: Lenovo X1 Carbon with MX-23 Fluxbox and Windows 10
Other: Raspberry Pi 5 with MX-23 Xfce Raspberry Pi Respin

User avatar
colin_b
Posts: 452
Joined: Sun Mar 19, 2017 7:21 pm

Re: Dark theme tweak

#3 Post by colin_b »

Jerry3904 wrote: Thu Jul 12, 2018 9:16 pm If you're not using persistence, it won't persist, right?
I am using persistence (honest).

User avatar
dolphin_oracle
Developer
Posts: 20009
Joined: Sun Dec 16, 2007 1:17 pm

Re: Dark theme tweak

#4 Post by dolphin_oracle »

are you just launching firefox from the menu? or do you have any custom launchers?

the tweak is designed to be used with "firefox" as the launch screen. or /usr/local/bin/firefox. /usr/bin/firefox will bypass the tweak.

our desktop files use "firefox" as the exec.
Last edited by dolphin_oracle on Thu Jul 12, 2018 9:32 pm, edited 1 time in total.
http://www.youtube.com/runwiththedolphin
lenovo ThinkPad X1 Extreme Gen 4 - MX-23
FYI: mx "test" repo is not the same thing as debian testing repo.

User avatar
colin_b
Posts: 452
Joined: Sun Mar 19, 2017 7:21 pm

Re: Dark theme tweak

#5 Post by colin_b »

I'm launching it from the whisker menu.

User avatar
dolphin_oracle
Developer
Posts: 20009
Joined: Sun Dec 16, 2007 1:17 pm

Re: Dark theme tweak

#6 Post by dolphin_oracle »

colin_b wrote: Thu Jul 12, 2018 9:31 pm I'm launching it from the whisker menu.
with the tweak enabled, launch "firefox" from the terminal, and post any output.

also, is adwaita themes present?


this is the entire tweak script (firefox.real is there to help deal with firefox-esr when installed via debian repos).

Code: Select all

#!/bin/bash

if [ -a /home/$USER/.config/FirefoxDarkThemeOverride.check ]; then
    if [ -e /usr/bin/firefox.real ]; then
        echo "Dark Theme Override"
        env GTK_THEME=Adwaita /usr/bin/firefox.real "$@"
    else
        echo "Dark Theme Override"
        env GTK_THEME=Adwaita /usr/bin/firefox "$@"
    fi
else
    if [ -e /usr/bin/firefox.real ]; then
        /usr/bin/firefox.real "$@"
    else
        /usr/bin/firefox "$@"
    fi
fi
http://www.youtube.com/runwiththedolphin
lenovo ThinkPad X1 Extreme Gen 4 - MX-23
FYI: mx "test" repo is not the same thing as debian testing repo.

User avatar
colin_b
Posts: 452
Joined: Sun Mar 19, 2017 7:21 pm

Re: Dark theme tweak

#7 Post by colin_b »

dolphin_oracle wrote: Thu Jul 12, 2018 9:33 pm with the tweak enabled, launch "firefox" from the terminal, and post any output.
I'm afraid the terminal is foreign to me.
dolphin_oracle wrote: Thu Jul 12, 2018 9:33 pm also, is adwaita themes present?
I've had a look in the window manager and I can't see it.

User avatar
dolphin_oracle
Developer
Posts: 20009
Joined: Sun Dec 16, 2007 1:17 pm

Re: Dark theme tweak

#8 Post by dolphin_oracle »

colin_b wrote: Thu Jul 12, 2018 9:39 pm
dolphin_oracle wrote: Thu Jul 12, 2018 9:33 pm with the tweak enabled, launch "firefox" from the terminal, and post any output.
I'm afraid the terminal is foreign to me.
dolphin_oracle wrote: Thu Jul 12, 2018 9:33 pm also, is adwaita themes present?
I've had a look in the window manager and I can't see it.
these screen shots will help you with what I ask.
You do not have the required permissions to view the files attached to this post.
http://www.youtube.com/runwiththedolphin
lenovo ThinkPad X1 Extreme Gen 4 - MX-23
FYI: mx "test" repo is not the same thing as debian testing repo.

User avatar
colin_b
Posts: 452
Joined: Sun Mar 19, 2017 7:21 pm

Re: Dark theme tweak

#9 Post by colin_b »

My apologies for being a dummy :confused:

I've found the adwaita theme.

I ran FF from the terminal and the problem does not occur. The terminal briefly flashed up something about the dark theme tweak before FF sprang to life.

User avatar
dolphin_oracle
Developer
Posts: 20009
Joined: Sun Dec 16, 2007 1:17 pm

Re: Dark theme tweak

#10 Post by dolphin_oracle »

ok, now some output for the firefox launcher in the menu.

Code: Select all

cat /usr/share/applications/firefox.desktop 
cat /home/$USER/.local/share/firefox.desktop
thanks!
http://www.youtube.com/runwiththedolphin
lenovo ThinkPad X1 Extreme Gen 4 - MX-23
FYI: mx "test" repo is not the same thing as debian testing repo.

Post Reply

Return to “Bugs and Non-Package Requests Forum”