Page 1 of 1

MX Kernel Installer: Minor Continue/Abort scripting bug

Posted: Fri Aug 10, 2018 8:46 am
by clicktician
I noticed an unexpected behavior when I install the latest liquorix kernel using the MX Package Installer in MX17.1.

If I reply "n" to the prompt "Do you want to continue? [Y/n]" the script acknowledges my abort instruction by displaying "Abort", but then proceeds with the process anyway -- apparently ignoring my reply.

NOTE: The "####" hash marks in the log are my own, to help locate the pertinent message line.

Code: Select all

The following additional packages will be installed:
  linux-headers-4.17.0-13.1-liquorix-amd64
  linux-image-4.17.0-13.1-liquorix-amd64
Suggested packages:
  linux-doc-4.17 crda
The following NEW packages will be installed:
  linux-headers-4.17.0-13.1-liquorix-amd64 linux-headers-liquorix-amd64
  linux-image-4.17.0-13.1-liquorix-amd64 linux-image-liquorix-amd64
0 upgraded, 4 newly installed, 2 reinstalled, 0 to remove and 100 not upgraded.
Need to get 65.7 MB of archives.
After this operation, 358 MB of additional disk space will be used.
##########################################
Do you want to continue? [Y/n] Abort.
##########################################
Reading package lists...
Building dependency tree...
Reading state information...
Hit:1 http://mxrepo.com/mx/repo stretch InRelease
Hit:2 http://deb.debian.org/debian stretch-backports InRelease
Hit:3 http://security.debian.org stretch/updates InRelease
Hit:4 http://ftp.us.debian.org/debian stretch-updates InRelease
Hit:5 http://repo.antixlinux.com/stretch stretch InRelease
Ign:6 http://ftp.us.debian.org/debian stretch InRelease
Hit:7 http://ftp.us.debian.org/debian stretch Release
Ign:8 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:9 http://dl.google.com/linux/chrome/deb stable Release
Reading package lists...

-------- Uninstall Beginning --------
Module:  broadcom-sta
Version: 6.30.223.271
Kernel:  4.17.0-10.1-liquorix-amd64 (x86_64)
-------------------------------------

Status: Before uninstall, this module version was ACTIVE on this kernel.

wl.ko:
 - Uninstallation
   - Deleting from: /lib/modules/4.17.0-10.1-liquorix-amd64/updates/dkms/
 - Original module
   - No original module was found for this module on this kernel.
   - Use the dkms install command to reinstall any previous module version.

depmod....

Backing up initrd.img-4.17.0-10.1-liquorix-amd64 to /boot/initrd.img-4.17.0-10.1-liquorix-amd64.old-dkms
Making new initrd.img-4.17.0-10.1-liquorix-amd64
(If next boot fails, revert to initrd.img-4.17.0-10.1-liquorix-amd64.old-dkms image)
update-initramfs.....

DKMS: uninstall completed.
.....<remaining log entries deleted>
Also, if the latest kernel is already installed, it doesn't display the prompt. Instead, it just goes ahead and reinstalls the latest from the repository.
So, while you have the code checked out... <lol> it would be nice to have the prompt always displayed so I could prevent this if it is undesired. But please don't take that too far and auto-abort if the latest is installed because I may have corrupted my kernel and my intention is to reinstall it.

Re: MX Kernel Installer: Minor Continue/Abort scripting bug

Posted: Fri Aug 10, 2018 8:50 am
by dolphin_oracle
thanks for the comment.

quick point, and I need to think about how to deal with it, is that you did abort the kernel install, and that kernel did not install, but we still rebuilt the dkms kernel modules and reset the repos. The repo resetting is by design, but the dkms module probably needs a check to make sure the package is actually installed before proceeding with the rebuild.