wait for terminal in a script

[Vincent17]

I have a script which should open an interactive terminal, then wait for it to close before continuing. Using

Code: Select all

xfce4-terminal -x bash -ic "command1"
command2 

command2 executes immediately. The only reasonable solution I have found is to insert

Code: Select all

while [[ -n $(pgrep command1) ]] ; do sleep 1 ; done

before command2. But if command1 is running elsewhere, I have to resort to

Code: Select all

xfce4-terminal -x bash -ic "command1" UniqueID
while [[ -n $(ps a | awk '/UniqueID/&&!/awk/') ]] ; do sleep 1 ; done
command2 

which is ugly.

How is a neater way to accomplish this?

[sunrat]

So you want command1 to complete before running command2?

Code: Select all

command1 && command2

Somehow I feel that's not what you want as it seems too obvious.
If your "ugly" code works as intended, be happy. It's not as if you want to take it to the royal ball or anything. :D

[fehlix]

How is a neater way to accomplish this?

something like

Code: Select all

xfce4-terminal -e 'bash -c "echo Count_down; for i in {9..0}; do echo $i; sleep 1; done; read -p Ready_for_Take_Off_Hit_any_key " '
echo Beam_me_Up_Scotty

EDit: Opps, doesn do waht you want as it don't wait ...

[Adrian]

Why not:

Code: Select all

xfce4-terminal -x bash -ic "command1"; command2 

And if you want to run command2 only if command1 returns true use && instead of ;

[fehlix]

OK, I need to wait until scotty is ready ...

Code: Select all

xfce4-terminal -x bash -ic 'echo Count_down; for i in {9..0}; do echo $i; sleep 1; done; read -p Ready_for_Take_Off_Hit_any_key ; touch /tmp/Ready_for_Take_off ' 
while [ ! -f /tmp/Ready_for_Take_off ] ; do :  ; sleep .1 ; done 
echo Beam_me_Up_Scotty

This will wait unti Ready_for_Take_off before Scotty "Beams me Up"

[fehlix]

Now we got a signal before Take_Off:

Code: Select all

xfce4-terminal -x bash -ic 'echo Count_down; for i in {9..0}; do echo $i; sleep 1; done; read -p Ready_for_Take_Off_Hit_any_key ; [ -f /tmp/Waiting_for_TakeOff ] && { xargs kill -s CONT < /tmp/Waiting_for_TakeOff ;   rm -f /tmp/Waiting_for_TakeOff ;   } '

echo $$ >> /tmp/Waiting_for_TakeOff 
kill -s STOP $$
echo Beam_me_Up_Scotty

[Vincent17]

Thanks for the repies!
@Adrian Does that work for you? Here, "terminal terminated?" appears immediately

Code: Select all

xfce4-terminal -x bash -ic "sleep 10" ; echo "terminal terminated?"

@ fehlix Your script certainly does what I want, and I love the Star Trek theme, but I'm not sure it's light years neater Seriously, an indicator file is a good idea.

If your "ugly" code works as intended, be happy.

I get confused when a script exceeds about 40 lines, so every line counts!

[Adrian]

Thanks for the repies!
@Adrian Does that work for you? Here, "terminal terminated?" appears immediately

Code: Select all

xfce4-terminal -x bash -ic "sleep 10" ; echo "terminal terminated?"

No, you are right, the command is forked, returns 0 for success and then the next command is executed immediately.

[Adrian]

This works though...

Code: Select all

xfce4-terminal --disable-server -x bash -ic "sleep 10" ; echo "terminal terminated?"

[penguin]

I use the follow:

read -t 3 -p "Wait for 3 seconds or Hit Enter ...."

The script will wait 3 seconds for input or will execute next line.