Scripting help needed... [SOLVED]

[Head_on_a_Stick]

Code: Select all

#bin/bash

If you want to explicitly specify bash for your script then you need to add an exclamation mark after the # symbol to make a shebang.

However, bash is bloated, buggy & slow and your script does not use any of the special features of that shell (known as bashisms) so you could speed it up by using a POSIX shebang instead:

Code: Select all

#!/bin/sh

In MX /bin/sh is symlinked to dash and that is preferred over bash for system scripts.

Silly benchmark:

Code: Select all

E485:~$ time bash -c 'for i in $(seq 1 1000000);do [ 1 = 1 ];done'
    0m03.97s real     0m03.83s user     0m00.16s system
E485:~$ time dash -c 'for i in $(seq 1 1000000);do [ 1 = 1 ];done'
    0m01.45s real     0m01.42s user     0m00.06s system
E485:~$

So dash is more than twice as fast as bash, uses less memory and is less buggy. The difference won't really be apparent for your one-liner but it is the best option.

[manyroads]

Thank you @Head_on_a_Stick. I have made the change.

EDIT The #!/bin/sh made a mess of the formatting... I changed it to: #!/bin/bash Things seem okay now.